[Slim-Checkins] r11123 - in /trunk/server: HTML/EN/settings/ Slim/Web/ Slim/Web/Settings/Player/ Slim/Web/Settings/Server/

mherger at svn.slimdevices.com mherger at svn.slimdevices.com
Fri Jan 5 22:25:20 PST 2007


Author: mherger
Date: Fri Jan  5 22:25:20 2007
New Revision: 11123

URL: http://svn.slimdevices.com?rev=11123&view=rev
Log:
Bug: N/A
Description: rename submit button to prevent unwanted side effects with javascript

Modified:
    trunk/server/HTML/EN/settings/footer.html
    trunk/server/Slim/Web/Settings.pm
    trunk/server/Slim/Web/Settings/Player/Alarm.pm
    trunk/server/Slim/Web/Settings/Player/Audio.pm
    trunk/server/Slim/Web/Settings/Player/Basic.pm
    trunk/server/Slim/Web/Settings/Player/Display.pm
    trunk/server/Slim/Web/Settings/Player/Remote.pm
    trunk/server/Slim/Web/Settings/Server/Basic.pm
    trunk/server/Slim/Web/Settings/Server/Behavior.pm
    trunk/server/Slim/Web/Settings/Server/Debugging.pm
    trunk/server/Slim/Web/Settings/Server/FileTypes.pm
    trunk/server/Slim/Web/Settings/Server/Network.pm
    trunk/server/Slim/Web/Settings/Server/Performance.pm
    trunk/server/Slim/Web/Settings/Server/Plugins.pm
    trunk/server/Slim/Web/Settings/Server/Security.pm
    trunk/server/Slim/Web/Settings/Server/TextFormatting.pm
    trunk/server/Slim/Web/Settings/Server/UserInterface.pm

Modified: trunk/server/HTML/EN/settings/footer.html
URL: http://svn.slimdevices.com/trunk/server/HTML/EN/settings/footer.html?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/HTML/EN/settings/footer.html (original)
+++ trunk/server/HTML/EN/settings/footer.html Fri Jan  5 22:25:20 2007
@@ -1,6 +1,6 @@
 <!-- Begin settingsfooter.html -->
 [% IF prefs || NOT playerid %]
-	[% IF NOT nosubmit %]<p><input name="submit" type="submit" class="stdclick" value="[% "SAVE_SETTINGS" | string %]"></p>[% END %]
+	[% IF NOT nosubmit %]<p><input name="saveSettings" type="submit" class="stdclick" value="[% "SAVE_SETTINGS" | string %]"></p>[% END %]
 [% END %]
 
 [% IF versionInfo %]<p>

Modified: trunk/server/Slim/Web/Settings.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings.pm (original)
+++ trunk/server/Slim/Web/Settings.pm Fri Jan  5 22:25:20 2007
@@ -64,7 +64,7 @@
 
 	for my $pref (@prefs) {
 
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 
 			Slim::Utils::Prefs::set($pref, $paramRef->{$pref});
 		}

Modified: trunk/server/Slim/Web/Settings/Player/Alarm.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Player/Alarm.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Player/Alarm.pm (original)
+++ trunk/server/Slim/Web/Settings/Player/Alarm.pm Fri Jan  5 22:25:20 2007
@@ -31,7 +31,7 @@
 	my @prefs = qw(alarmfadeseconds alarm alarmtime alarmvolume alarmplaylist);
 	
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		my @changed = ();
 

Modified: trunk/server/Slim/Web/Settings/Player/Audio.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Player/Audio.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Player/Audio.pm (original)
+++ trunk/server/Slim/Web/Settings/Player/Audio.pm Fri Jan  5 22:25:20 2007
@@ -76,7 +76,7 @@
 	}
 	
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		my @changed = ();
 

Modified: trunk/server/Slim/Web/Settings/Player/Basic.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Player/Basic.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Player/Basic.pm (original)
+++ trunk/server/Slim/Web/Settings/Player/Basic.pm Fri Jan  5 22:25:20 2007
@@ -49,7 +49,7 @@
 	}
 	
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		my @changed = ();
 

Modified: trunk/server/Slim/Web/Settings/Player/Display.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Player/Display.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Player/Display.pm (original)
+++ trunk/server/Slim/Web/Settings/Player/Display.pm Fri Jan  5 22:25:20 2007
@@ -58,7 +58,7 @@
 		}
 
 		# If this is a settings update
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 	
 			for my $pref (@prefs) {
 	

Modified: trunk/server/Slim/Web/Settings/Player/Remote.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Player/Remote.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Player/Remote.pm (original)
+++ trunk/server/Slim/Web/Settings/Player/Remote.pm Fri Jan  5 22:25:20 2007
@@ -38,7 +38,7 @@
 		}
 		
 		# If this is a settings update
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 	
 			my @changed = ();
 

Modified: trunk/server/Slim/Web/Settings/Server/Basic.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Basic.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Basic.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Basic.pm Fri Jan  5 22:25:20 2007
@@ -33,7 +33,8 @@
 	}
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
+logger('scan.scanner')->info("saveSettings");
 
 		if ($paramRef->{'language'} ne Slim::Utils::Prefs::get('language')) {
 		

Modified: trunk/server/Slim/Web/Settings/Server/Behavior.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Behavior.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Behavior.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Behavior.pm Fri Jan  5 22:25:20 2007
@@ -47,7 +47,7 @@
 	for my $pref (@prefs) {
 
 		# If this is a settings update
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 
 			if (exists $scanOn{$pref} && $paramRef->{$pref} ne Slim::Utils::Prefs::get($pref)) {
 

Modified: trunk/server/Slim/Web/Settings/Server/Debugging.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Debugging.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Debugging.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Debugging.pm Fri Jan  5 22:25:20 2007
@@ -25,7 +25,7 @@
 	my ($class, $client, $paramRef, $pageSetup) = @_;
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		my $categories = Slim::Utils::Log->allCategories;
 

Modified: trunk/server/Slim/Web/Settings/Server/FileTypes.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/FileTypes.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/FileTypes.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/FileTypes.pm Fri Jan  5 22:25:20 2007
@@ -26,7 +26,7 @@
 	my ($class, $client, $paramRef, $pageSetup) = @_;
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		Slim::Utils::Prefs::set('disabledextensionsaudio',    $paramRef->{'disabledextensionsaudio'});
 		Slim::Utils::Prefs::set('disabledextensionsplaylist', $paramRef->{'disabledextensionsplaylist'});

Modified: trunk/server/Slim/Web/Settings/Server/Network.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Network.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Network.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Network.pm Fri Jan  5 22:25:20 2007
@@ -45,7 +45,7 @@
 	}
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		$paramRef->{'warning'} = "";
 

Modified: trunk/server/Slim/Web/Settings/Server/Performance.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Performance.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Performance.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Performance.pm Fri Jan  5 22:25:20 2007
@@ -36,7 +36,7 @@
 
 	for my $pref (@prefs) {
 
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 
 			Slim::Utils::Prefs::set($pref, $paramRef->{$pref});
 		}

Modified: trunk/server/Slim/Web/Settings/Server/Plugins.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Plugins.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Plugins.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Plugins.pm Fri Jan  5 22:25:20 2007
@@ -25,7 +25,7 @@
 	my ($class, $client, $paramRef) = @_;
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		# XXXX - handle install / uninstall / enable / disable
 

Modified: trunk/server/Slim/Web/Settings/Server/Security.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/Security.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/Security.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/Security.pm Fri Jan  5 22:25:20 2007
@@ -25,7 +25,7 @@
 
 	for my $pref (@prefs) {
 
-		if ($paramRef->{'submit'}) {
+		if ($paramRef->{'saveSettings'}) {
 
 			Slim::Utils::Prefs::set($pref, $paramRef->{$pref});
 		}

Modified: trunk/server/Slim/Web/Settings/Server/TextFormatting.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/TextFormatting.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/TextFormatting.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/TextFormatting.pm Fri Jan  5 22:25:20 2007
@@ -33,7 +33,7 @@
 	);
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		for my $pref (@prefs) {
 

Modified: trunk/server/Slim/Web/Settings/Server/UserInterface.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Web/Settings/Server/UserInterface.pm?rev=11123&r1=11122&r2=11123&view=diff
==============================================================================
--- trunk/server/Slim/Web/Settings/Server/UserInterface.pm (original)
+++ trunk/server/Slim/Web/Settings/Server/UserInterface.pm Fri Jan  5 22:25:20 2007
@@ -30,7 +30,7 @@
 	my @prefs = qw(skin itemsPerPage refreshRate coverArt artfolder thumbSize);
 
 	# If this is a settings update
-	if ($paramRef->{'submit'}) {
+	if ($paramRef->{'saveSettings'}) {
 
 		$paramRef->{'warning'} = "";
 



More information about the checkins mailing list