[Slim-Checkins] r11805 - in /trunk/server/Slim/Buttons: Block.pm XMLBrowser.pm

andy at svn.slimdevices.com andy at svn.slimdevices.com
Tue Apr 24 11:20:32 PDT 2007


Author: andy
Date: Tue Apr 24 11:20:32 2007
New Revision: 11805

URL: http://svn.slimdevices.com?rev=11805&view=rev
Log:
Remove 'Fetching...' text from XMLBrowser while loading a remote URL.  Allow client->block() to work as expected with no params

Modified:
    trunk/server/Slim/Buttons/Block.pm
    trunk/server/Slim/Buttons/XMLBrowser.pm

Modified: trunk/server/Slim/Buttons/Block.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/Block.pm?rev=11805&r1=11804&r2=11805&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/Block.pm (original)
+++ trunk/server/Slim/Buttons/Block.pm Tue Apr 24 11:20:32 2007
@@ -97,7 +97,11 @@
 
 	my $parts  = $line1;
 
-	if (ref($line1) ne 'HASH') {
+	if ( !$line1 ) {
+		# Default to what's currently on the screen
+		$parts = $client->curDisplay();
+	}
+	elsif (ref($line1) ne 'HASH') {
 
 		$parts = $client->parseLines( { 'line' => [ $line1, shift] } );
 	}

Modified: trunk/server/Slim/Buttons/XMLBrowser.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/XMLBrowser.pm?rev=11805&r1=11804&r2=11805&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/XMLBrowser.pm (original)
+++ trunk/server/Slim/Buttons/XMLBrowser.pm Tue Apr 24 11:20:32 2007
@@ -82,14 +82,7 @@
 		my $item = $client->modeParam('item');
 
 		# give user feedback while loading
-		my $string = $client->modeParam('header');
-
-		$string = Slim::Utils::Strings::stringExists($string) ? $client->string($string) : $client->string('XML_LOADING');
-
-		$client->block(
-			$string,
-			$title || $url,
-		);
+		$client->block();
 		
 		# Some plugins may give us a callback we should use to get OPML data
 		# instead of fetching it ourselves.
@@ -839,10 +832,7 @@
 
 		# URL is remote, load it asynchronously...
 		# give user feedback while loading
-		$client->block(
-			$client->string('XML_LOADING'),
-			$title || $url,
-		);
+		$client->block();
 		
 		# we may have a callback as URL
 		if ( ref $url eq 'CODE' ) {



More information about the checkins mailing list