[Slim-Checkins] r10059 - in /trunk/server: Changelog6.html HTML/Fishbone/html/ajax.js HTML/Fishbone/status_header.html

[kdf at svn.slimdevices.com]

Author: kdf
Date: Tue Sep 26 22:27:09 2006
New Revision: 10059

URL: http://svn.slimdevices.com?rev=10059&view=rev
Log:
Bug: 4228
Description: fix fishbone status update for player UI added tracks to an empty playlist


Modified:
    trunk/server/Changelog6.html
    trunk/server/HTML/Fishbone/html/ajax.js
    trunk/server/HTML/Fishbone/status_header.html

Modified: trunk/server/Changelog6.html
URL: http://svn.slimdevices.com/trunk/server/Changelog6.html?rev=10059&r1=10058&r2=10059&view=diff
==============================================================================
--- trunk/server/Changelog6.html (original)
+++ trunk/server/Changelog6.html Tue Sep 26 22:27:09 2006
@@ -17,6 +17,7 @@
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=4191">#4191</a> - Live365 Search has missing strings</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=4192">#4192</a> - IE doesn't refresh status</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=4221">#4221</a> - 6.5 crashes on artist breadcrumb</li>
+		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=4228">#4228</a> - Fishbone skin status doesn't update from an empty playlist</li>
 	<ul>
 </ul>
 

Modified: trunk/server/HTML/Fishbone/html/ajax.js
URL: http://svn.slimdevices.com/trunk/server/HTML/Fishbone/html/ajax.js?rev=10059&r1=10058&r2=10059&view=diff
==============================================================================
--- trunk/server/HTML/Fishbone/html/ajax.js (original)
+++ trunk/server/HTML/Fishbone/html/ajax.js Tue Sep 26 22:27:09 2006
@@ -190,10 +190,11 @@
 	var a = rExp.exec(myString);
 	var newsong = 1;
 
-	if (force != 1) {
+	if (force != 1 && !(parsedData['songtitleid'] && $('nowplaying').style.display == 'none')) {
 		if (a == null || a[1] == parsedData['songtitleid']) {newsong = 0;}
 	}
 	
+	//alert([newsong,parsedData['songtitleid'] ,$('nowplaying').style.display]);
 	var elems = ['thissongnum', 'playtextmode', 'songcount'];
 	if (newsong) {
 		elems.push('songtitle');
@@ -256,12 +257,12 @@
 	
 	// refresh href content
 	if (newsong) {
-		refreshHrefElement('albumhref',parsedData['albumid'],"album.id=");
-		refreshHrefElement('coverhref',parsedData['albumid'],"album.id=");
-		refreshHrefElement('removealbumhref',parsedData['album'],"p4=");
-		refreshHrefElement('removeartisthref',parsedData['artist'],"p3=");
-		refreshHrefElement('songtitlehref',parsedData['songtitleid'],"item=");
-		refreshHrefElement('zaphref',parsedData['thissongnum']-1,"p2=");
+		refreshHrefElement('albumhref', parsedData['albumid'],"album.id=");
+		refreshHrefElement('coverhref', parsedData['albumid'],"album.id=");
+		refreshHrefElement('removealbumhref', parsedData['album'],"p4=");
+		refreshHrefElement('removeartisthref', parsedData['artist'],"p3=");
+		refreshHrefElement('songtitlehref', parsedData['songtitleid'],"item=");
+		refreshHrefElement('zaphref', parsedData['thissongnum']-1,"p2=");
 		currentID = parsedData['songtitleid'];
 	}
 

Modified: trunk/server/HTML/Fishbone/status_header.html
URL: http://svn.slimdevices.com/trunk/server/HTML/Fishbone/status_header.html?rev=10059&r1=10058&r2=10059&view=diff
==============================================================================
--- trunk/server/HTML/Fishbone/status_header.html (original)
+++ trunk/server/HTML/Fishbone/status_header.html Tue Sep 26 22:27:09 2006
@@ -134,7 +134,7 @@
 			<div id="nowplaying" [% IF NOT currentsong %]style="display:none;"[% END %]>
 				<div class="label">[% IF modeplay  %][% status = "PLAYING"    %][% END %][% IF modepause %][% status = "PAUSED_ON"  %][% END %][% IF modestop  %][% status = "STOPPED_ON" %][% END %]
 				<span id="playtextmode">[% IF currentsong %][% status | string %][% END %]</span>
-				<span id="thissongnum">[% IF currentsong %][% currentsong %][% END %]</span><span id="outof">&nbsp;[% "OUT_OF" | string %]&nbsp;</span><span id="songcount">[% IF songcount %][% songcount %][% END %]</span>&nbsp;<span id="zaphref">[% IF currentsong %]<a class="label" href="[% statusroot %]?p0=playlist&amp;p1=zap&amp;p2=[% thissongnum %]&amp;player=[% playerURI %]" title='Move to Zapped playlist'>[zap]</a>[% END %]</span>[% IF currentsong %][% "COLON" | string %][% END %]</div>
+				<span id="thissongnum">[% IF currentsong %][% currentsong %][% END %]</span><span id="outof">&nbsp;[% "OUT_OF" | string %]&nbsp;</span><span id="songcount">[% IF songcount %][% songcount %][% END %]</span>&nbsp;<span id="zaphref"><a class="label" href="[% statusroot %]?p0=playlist&amp;p1=zap&amp;p2=[% thissongnum %]&amp;player=[% playerURI %]" title='Move to Zapped playlist'>[zap]</a></span>[% "COLON" | string %]</div>
 				<div id="songtitlehref" class="currentSongData"><a class="songtitle" [% songinfoHRef %] target="browser"><span id="songtitle">[% songtitle %]</span></a>
 				&nbsp;<span id="duration">[% IF itemobj.duration %]([% itemobj.duration | html %])[% END %]</span>&nbsp;<span id="bitrate">[% IF bitrate %]([% bitrate %])[% END %]</span></div>