[Slim-Checkins] r9923 - in /trunk/server/Slim: Buttons/Block.pm Networking/Slimproto.pm

adrian at svn.slimdevices.com adrian at svn.slimdevices.com
Wed Sep 20 15:35:43 PDT 2006


Author: adrian
Date: Wed Sep 20 15:35:40 2006
New Revision: 9923

URL: http://svn.slimdevices.com?rev=9923&view=rev
Log:
Bug: 4159
Description: blank screen2 when showing upgrade prompt

Modified:
    trunk/server/Slim/Buttons/Block.pm
    trunk/server/Slim/Networking/Slimproto.pm

Modified: trunk/server/Slim/Buttons/Block.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/Block.pm?rev=9923&r1=9922&r2=9923&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/Block.pm (original)
+++ trunk/server/Slim/Buttons/Block.pm Wed Sep 20 15:35:40 2006
@@ -60,6 +60,8 @@
 sub setMode {
 	my $client = shift;
 
+	$client->modeParam('screen2', 'inherit');
+
 	# store current lines function so it can be replaced when block mode is popped
 	# this is required as popping block mode does not call the setMode of the previous mode
 	$client->modeParam('oldLines', $client->lines );
@@ -104,12 +106,9 @@
 
 	$client->blocklines( { 'static' => $static, 'parts' => $parts, 'ticks' => 0 } );
 
-	my $screen2mode = $client->modeParam('screen2');
-
 	Slim::Buttons::Common::pushMode($client, 'block');
 
 	$client->modeParam('block.name', $blockName);
-	$client->modeParam('screen2', $screen2mode);
 
 	if (ref($parts) eq 'HASH') {
 

Modified: trunk/server/Slim/Networking/Slimproto.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Networking/Slimproto.pm?rev=9923&r1=9922&r2=9923&view=diff
==============================================================================
--- trunk/server/Slim/Networking/Slimproto.pm (original)
+++ trunk/server/Slim/Networking/Slimproto.pm Wed Sep 20 15:35:40 2006
@@ -878,14 +878,21 @@
 		$client->sendFrame('ureq');
 
 		$client->brightness($client->maxBrightness());
+
+		# turn of visualizers and screen2 display
+		$client->modeParam('visu', [0]);
+		$client->modeParam('screen2active', undef);
 		
 		$client->block( {
-			'line' => [ string('PLAYER_NEEDS_UPGRADE_1'), string('PLAYER_NEEDS_UPGRADE_2') ],
-			'fonts' => { 
-				'graphic-320x32' => 'light',
-				'graphic-280x16' => 'small',
-				'text'           => 2,
-			}
+			'screen1' => {
+				'line' => [ string('PLAYER_NEEDS_UPGRADE_1'), string('PLAYER_NEEDS_UPGRADE_2') ],
+				'fonts' => { 
+					'graphic-320x32' => 'light',
+					'graphic-280x16' => 'small',
+					'text'           => 2,
+				}
+			},
+			'screen2' => {},
 		}, 'upgrade');
 
 	} else {



More information about the checkins mailing list