[Slim-Checkins] r9757 - in /trunk/server/Slim: Buttons/Input/Choice.pm Buttons/Input/List.pm Buttons/Playlist.pm Player/Transporter.pm

[adrian at svn.slimdevices.com]

Author: adrian
Date: Fri Sep 15 13:20:54 2006
New Revision: 9757

URL: http://svn.slimdevices.com?rev=9757&view=rev
Log:
Bug: 3572
Description: don't bump for 1 postion list when knob returns centre position

Modified:
    trunk/server/Slim/Buttons/Input/Choice.pm
    trunk/server/Slim/Buttons/Input/List.pm
    trunk/server/Slim/Buttons/Playlist.pm
    trunk/server/Slim/Player/Transporter.pm

Modified: trunk/server/Slim/Buttons/Input/Choice.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/Input/Choice.pm?rev=9757&r1=9756&r2=9757&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/Input/Choice.pm (original)
+++ trunk/server/Slim/Buttons/Input/Choice.pm Fri Sep 15 13:20:54 2006
@@ -187,7 +187,7 @@
 
 		my ($newPos, $dir, $pushDir, $wrap) = $client->knobListPos();
 		
-		changePos($client, $dir, $funct, $pushDir);
+		changePos($client, $dir, $funct, $pushDir) if $pushDir;
 	},
 	'numberScroll' => sub {
 		my ($client, $funct, $functarg) = @_;

Modified: trunk/server/Slim/Buttons/Input/List.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/Input/List.pm?rev=9757&r1=9756&r2=9757&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/Input/List.pm (original)
+++ trunk/server/Slim/Buttons/Input/List.pm Fri Sep 15 13:20:54 2006
@@ -73,7 +73,7 @@
 
 		my ($newPos, $dir, $pushDir, $wrap) = $client->knobListPos();
 		
-		changePos($client, $dir, $funct, $pushDir);
+		changePos($client, $dir, $funct, $pushDir) if $pushDir;
 	},
 
 	'numberScroll' => sub {

Modified: trunk/server/Slim/Buttons/Playlist.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Buttons/Playlist.pm?rev=9757&r1=9756&r2=9757&view=diff
==============================================================================
--- trunk/server/Slim/Buttons/Playlist.pm (original)
+++ trunk/server/Slim/Buttons/Playlist.pm Fri Sep 15 13:20:54 2006
@@ -113,7 +113,11 @@
 
 				if ($songcount < 2) {
 					
-					$pushDir eq 'up' ? $client->bumpUp : $client->bumpDown;
+					if ($pushDir) {
+
+						$pushDir eq 'up' ? $client->bumpUp : $client->bumpDown;
+
+					}
 
 				} else {
 

Modified: trunk/server/Slim/Player/Transporter.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Player/Transporter.pm?rev=9757&r1=9756&r2=9757&view=diff
==============================================================================
--- trunk/server/Slim/Player/Transporter.pm (original)
+++ trunk/server/Slim/Player/Transporter.pm Fri Sep 15 13:20:54 2006
@@ -180,7 +180,13 @@
 	if ($listLen == 1) {
 
 		# knob return negative value anti-clockwise and +1 for clockwise
-		$direction = $newPos > 0 ? 'up' : 'down';
+		# set direction only if a bump is required otherwise leave as undef
+		if ($newPos > 0) {
+			$direction = 'up';
+		} elsif($newPos < 0) {
+			$direction = 'down';
+		}
+
 		$newPos = $curPos;
 
 	} elsif ($listLen == 2) {