[Slim-Checkins] r9418 - /trunk/server/Slim/Player/Squeezebox2.pm

titmuss at svn.slimdevices.com titmuss at svn.slimdevices.com
Mon Sep 4 14:46:51 PDT 2006


Author: titmuss
Date: Mon Sep  4 14:46:49 2006
New Revision: 9418

URL: http://svn.slimdevices.com?rev=9418&view=rev
Log:
When synchronizing the settings between the firmware and 
slimserver don't send a NULL string. This causes an infinate loop, much 
network traffic and bad player performance.

Modified:
    trunk/server/Slim/Player/Squeezebox2.pm

Modified: trunk/server/Slim/Player/Squeezebox2.pm
URL: http://svn.slimdevices.com/trunk/server/Slim/Player/Squeezebox2.pm?rev=9418&r1=9417&r2=9418&view=diff
==============================================================================
--- trunk/server/Slim/Player/Squeezebox2.pm (original)
+++ trunk/server/Slim/Player/Squeezebox2.pm Mon Sep  4 14:46:49 2006
@@ -696,6 +696,8 @@
 	my $pref = shift;
 	my $value = shift;
 
+	return if !defined $value;
+
 	$::d_prefs && msg("setPlayerSetting $pref = $value\n");
 
 	my $currpref = $pref_settings->{$pref};



More information about the checkins mailing list