[Slim-Checkins] r8759 - in /trunk/server: Bin/build-perl-modules.pl Changelog6.html

[dsully at svn.slimdevices.com]

Author: dsully
Date: Tue Aug  1 14:05:36 2006
New Revision: 8759

URL: http://svn.slimdevices.com?rev=8759&view=rev
Log:
Bug: 3834
Description: Use File::Which instead of a system dependent which(1) command.

Modified:
    trunk/server/Bin/build-perl-modules.pl
    trunk/server/Changelog6.html

Modified: trunk/server/Bin/build-perl-modules.pl
URL: http://svn.slimdevices.com/trunk/server/Bin/build-perl-modules.pl?rev=8759&r1=8758&r2=8759&view=diff
==============================================================================
--- trunk/server/Bin/build-perl-modules.pl (original)
+++ trunk/server/Bin/build-perl-modules.pl Tue Aug  1 14:05:36 2006
@@ -17,6 +17,7 @@
 use File::Copy;
 use File::Find;
 use File::Path;
+use File::Which;
 
 my $SOURCE = 'http://svn.slimdevices.com/vendor/src';
 my $dlext  = $Config{'dlext'};
@@ -131,10 +132,7 @@
 
 		for my $cmd (qw(curl wget)) {
 
-			system("which $cmd >/dev/null 2>&1");
-
-			unless ($? >> 8) {
-				$downloadUsing = $cmd;
+			if ($downloadUsing = which($cmd)) {
 				last;
 			}
 		}

Modified: trunk/server/Changelog6.html
URL: http://svn.slimdevices.com/trunk/server/Changelog6.html?rev=8759&r1=8758&r2=8759&view=diff
==============================================================================
--- trunk/server/Changelog6.html (original)
+++ trunk/server/Changelog6.html Tue Aug  1 14:05:36 2006
@@ -452,6 +452,7 @@
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3831">#3831</a> - help-&gt;faq open in new window</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3832">#3832</a> - Play All Songs on Player search</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3833">#3833</a> - Clean install crashes with undefined value in Import.pm</li>
+		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3834">#3834</a> - build-perl-modules.pl assumes that which exits with an error status</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3837">#3837</a> - Digital Input plugin should only appear on transporters</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3842">#3842</a> - Playing a magic favorite has some problems.</li>
 		<li><a href="http://bugs.slimdevices.com/show_bug.cgi?id=3843">#3843</a> - Undefined subroutine &Slim::Networking::Async::Socket::UDP::msg</li>